This repository was archived by the owner on Dec 21, 2021. It is now read-only.
Add rendering of template variables to environment variables#30
Merged
Conversation
Member
|
Would you mind merging main before I review? |
Member
Author
|
I've merged |
lfrancke
suggested changes
Dec 14, 2020
Member
lfrancke
left a comment
There was a problem hiding this comment.
I left a few comments but I'm mostly unsure what the "rust way" to do things would be here
matklad
reviewed
Dec 15, 2020
lfrancke
previously approved these changes
Dec 15, 2020
Member
lfrancke
left a comment
There was a problem hiding this comment.
One request but if you don't want to it's already good to go
Member
Author
|
I've added the comment you asked for. |
lfrancke
approved these changes
Dec 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #29